search

google / openrtb

OpenRTB model for Java and other languages via protobuf; Helper OpenRTB libraries for Java including JSON serialization
Apache License 2.0
398 stars 190 forks source link

Allows context to be backwards compatible #17

Closed matzi11a closed 9 years ago

matzi11a commented 9 years ago

this is my first pull request so please excuse me if i have done something wrong.

context was string in 2.2 so changing to getValueAsInt fixes a parse exception.

here is an example bidrequest which failed before but works with the patch:

{"site":{"id":"1000046","name":"example.com","domain":"www.example.com","page":"http://www.example.com","ref":"http://www.test.com","content":{"id":"1316436782","url":"http://www.example.com","context":"5","sourcerelationship":1}},"id":"35c441517fd44a38b953479216fd5195","tmax":70,"imp":[{"id":"ae4f2508-3bcc-4893-be78-aa9cbfa49981","instl":0,"banner":{"h":250,"w":300,"api":null}}],"device":{"os":null,"model":null,"didsha1":null,"connectiontype":3,"geo":{"country":"FRA"},"dpidsha1":null,"osv":"0","ua":"mozilla/5.0 (windows nt 6.2; wow64) applewebkit/537.17 (khtml, like gecko) chrome/24.0.1312.57 safari/537.17","devicetype":1,"language":null,"dnt":1,"make":"","ip":"109.209.108.150"},"at":2,"user":{}}
matzi11a commented 9 years ago

Much better thanks for the feedback