Feature/native json object

google / openrtb

OpenRTB model for Java and other languages via protobuf; Helper OpenRTB libraries for Java including JSON serialization

Apache License 2.0

398 stars 190 forks source link

Feature/native json object #86

Closed bundeskanzler4711 closed 8 years ago

bundeskanzler4711 commented 8 years ago

According to https://github.com/google/openrtb/issues/85 this is my pull request.

Bid request:

no root-native field, native as request field (String)
including root-native field, native as request field (String)
no root-native field, native as request_native field (Json-Object) NEW
including root-native field, native as request_native field (Json-Object) NEW

Bid response:

no root-native field, native as adm field (String)
including root-native field, native as adm field (String)
no root-native field, native as adm_native field (Json-Object) NEW
including root-native field, native as adm_native field (Json-Object) NEW

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

bundeskanzler4711 commented 8 years ago

I signed it!

googlebot notifications@github.com schrieb am Mi., 18. Mai 2016 um 14:54 Uhr:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.

If you signed the CLA as a corporation, please let us know the company's name.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/google/openrtb/pull/86#issuecomment-220016820

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

bschev commented 8 years ago

I signed it!

2016-05-18 15:02 GMT+02:00 googlebot notifications@github.com:

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here https://cla.developers.google.com/ to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/google/openrtb/pull/86#issuecomment-220018911

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

bundeskanzler4711 commented 8 years ago

It's a mistake, only @bschev and @bundeskanzler4711 contributed to this pull request

bundeskanzler4711 commented 8 years ago

confirm

googlebot notifications@github.com schrieb am Mi., 18. Mai 2016 um 15:32 Uhr:

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/google/openrtb/pull/86#issuecomment-220026785

bschev commented 8 years ago

I confirm that I authored some of the commits.

bundeskanzler4711 commented 8 years ago

conflict -> close.