Closed leviorca closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Hello. Have you thought about passing these operators to Apache? In the next step, they will be available as a backport package/provider package, and these packages are installed by default in the Cloud Composer environment. This will significantly facilitate and promote their use. If you are interested, I will be happy to help.
@googlebot I signed it!
Thanks for this @leviorca. We will be adding a few comments this week.
@mik-laj thanks for the offer!
LGTM to me. I believe the next step will be to refactor this to use more generic Airflow, however I don't think that's a blocker.
The solution pulls conversions from SA360 using Google Search Ads API and uploads a copy to a new floodlight activity with a new revenue calculated deducting internal costs. Profitable_Sales _SA360_GCP_Automation.pdf