google / oss-fuzz-gen

LLM powered fuzzing via OSS-Fuzz.
Apache License 2.0
928 stars 106 forks source link

search_source() Function Requires Missing language Parameter in Configuration #644

Closed kalina2002 closed 1 month ago

kalina2002 commented 1 month ago

https://github.com/google/oss-fuzz-gen/tree/main/data_prep I have a question about project_src.py : search_source() function requires five parameters, but the configuration in your configs list only contains four parameters. The missing parameter is language, which is required by the search_source() function but not passed in the configuration. bug

it seems the language parameter will receive args.result_dir as its value .

DavidKorczynski commented 1 month ago

This is by and large because the main function use of search_source has been phased out. search_source is used for benchmark generation and this is primarily done by way of these args https://github.com/google/oss-fuzz-gen/blob/5fbf0a3c9c1e1d22c7be3e888d4633466f575115/run_all_experiments.py#L236-L253 or perhaps the logic from here: https://github.com/google/oss-fuzz-gen/blob/5fbf0a3c9c1e1d22c7be3e888d4633466f575115/data_prep/introspector.py#L1031 (although I personally always use the run_all_experiments.py to generate benchmarks.

We're also trying to face out the use of search_source as it adds a fair amount of overhead for generating benchmarks. The ideal situation is if we push this logic into introspector so we can generate it dynamically on a daily basis. I think the best is to delete the main calling into search_source.