search

google / oss-fuzz

OSS-Fuzz - continuous fuzzing for open source software.
https://google.github.io/oss-fuzz
Apache License 2.0
10.13k stars 2.15k forks source link

Update Clang toolchain from 18.0.0 to 18.1.7 #12077

Open alexcrichton opened 2 weeks ago

alexcrichton commented 2 weeks ago

This is done in the interest of assisting #12075 and #11626. Currently the Rust toolchain cannot be updated because the latest nightly uses LLVM 18.1.7 and coverage information breaks. This breakage is because LLVM 18.1.7 records coverage information with version "9" but LLVM 18.0.0 recorded coverage information with version "8". This means that the recordings created by Rust binaries use version "9" which are unreadable by the processing that OSS-Fuzz does with the 18.0.0-based toolchain using version "8".

This commit updates the Clang toolchain to the latest 18.x.x release to get the two in sync so the same coverage recording version is used.

alexcrichton commented 2 weeks ago

@maflcko you mentioned in https://github.com/google/oss-fuzz/issues/11626 that before doing this all existing projects should be un-pinned from their @sha256... pins. Is that required to bump Clang? I would have expected the other way around where some new projects might need pinning as a result of this.

Also, do you know of a way to more easily enumerate the projects which break as a result of this upate? I probably can't feasibly build everything locally. If CI takes care of this though I can also just wait for that.

alexcrichton commented 2 weeks ago

Also, for reference, I've confirmed that by layering #12075 on top of this Rust projects no longer have any warnings in coverage builds and coverage looks like it might work.

alexcrichton commented 2 weeks ago

Also, following up from your comment here you mentioned that pinned projects might break since they're using clang 15. I think though that the decoding of coverage data supports older versions, just not newer versions, so my assumption would be that LLVM 18 tooling would be able to decode clang 15-generated coverage information. I don't have data to back up this assumption, however.

jonathanmetzman commented 2 weeks ago

/gcbrun trial_build.py all

maflcko commented 2 weeks ago

Is that required to bump Clang?

Yes, because the coverage container uses the current llvm to parse the coverage profile (regardless of what the project uses), but if the profile was generated with llvm-15 (pinned projects) it will fail.

It should be possible to observe this in the trial build.

maflcko commented 2 weeks ago

LLVM 18 tooling would be able to decode clang 15-generated coverage information

In theory, yes, earlier coverage profiles can be read. However, the raw profile version is a separate versioning, and a breaking change every time, as far as I understood it.

maflcko commented 2 weeks ago

For reference, the trial build result is https://github.com/google/oss-fuzz/pull/12077/checks?check_run_id=26334505585:

Failed builds: 112/1020: {'ampproject': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-1baa1318-ff44-4132-98cc-8636a204c4db.txt', 'arrow': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-3cd88fc7-1175-4836-abca-486ee84a9558.txt', 'askama': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-d253f22f-f9b3-4b97-a5d8-55703f14ab52.txt', 'bignum-fuzzer': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-4721c69c-ceee-4fe3-822a-0c134d330d89.txt', 'bincode': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-a01f2477-8613-453b-9cce-19249d85ee68.txt', 'boost': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-cbf8f798-0949-4d20-8509-545e02bdbc7f.txt', 'boost-json': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-501c833f-7ab7-4edb-80a9-75fb8705fbac.txt', 'bson-rust': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-7e4990ef-32b0-4955-845c-8ef847116c49.txt', 'cloud-hypervisor': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-c0262abb-a0a5-4892-b1ba-4af67a8cd709.txt', 'cras': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-fd8d1f6b-bd96-4183-b137-48ffa61a8523.txt', 'crosvm': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-72f0d425-b0a7-47e8-a80e-81f9a8079ab3.txt', 'cryptofuzz': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-bf9ffa46-3e56-4db6-bd99-fc285007719d.txt', 'evo-inflector': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-fa1fd607-ee8d-4f08-bdac-d017e34778dd.txt', 'file': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-bd4566a2-1c2f-4446-a413-dbdd850f32ef.txt', 'flate2-rs': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-1aa8cc08-8d87-4b93-a2fa-d2f75937ae74.txt', 'fontations': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-70a9b0d4-878a-4299-97bd-4e910142ce55.txt', 'freeimage': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-ec7541b9-1ab2-4a36-9269-933f7c02e3ad.txt', 'gdbm': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-fd5d270f-12c4-437b-ac69-60c2d4b7b0e8.txt', 'gimli': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-5e6fa704-a6f2-4636-8a9b-c2023f8e2587.txt', 'gitoxide': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-555e1cc1-665b-42f8-a8d8-1f6f427824e2.txt', 'gnutls': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-13de2bcf-833e-469e-b298-6e87b8c4a989.txt', 'grpc-swift': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-fad133dd-71fc-4480-ae42-9c56e3179f3a.txt', 'hadoop': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-eba8387e-7055-461d-b2c1-613058a65abb.txt', 'hdf5': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-c3b8b921-b012-4d4f-b839-f8fba62f9f53.txt', 'httparse': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-6ec5fb70-e3a0-4460-abd1-83d89837fe3b.txt', 'hyperium': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-2f76969d-5e15-4b7b-99f0-6260bf51cb4b.txt', 'image-png': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-58cf0b4e-c1ab-4606-98ce-1c330114e97a.txt', 'immer': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-34f03349-8057-44c0-8971-a4f07bd2d7c1.txt', 'istio-ztunnel': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-9b6dc683-44a8-4c4e-8630-41957973c489.txt', 'itext7': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-580f58bf-4fa0-461d-b20c-0575343063d9.txt', 'itoa': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-1b5aced2-f923-40bc-a5c6-fb8135f9225e.txt', 'jackson-datatype-joda': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-c1f83a3e-1a84-42e1-b22c-e362746153a7.txt', 'javapoet': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-5de23b48-6518-4681-8955-ab5d14e580a8.txt', 'joni': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-3d565a0a-8c72-4cab-b842-a5445dcde364.txt', 'json-flattener': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-cd28232a-3f79-4fcb-a78b-43a24800fa4b.txt', 'json5format': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-748d2fbe-c271-4d09-b87a-d6f7474df528.txt', 'jsonp-api': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-9789e85a-46c2-439a-b99b-5d1100a94def.txt', 'kie-soup': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-20c9f4d6-a398-4afb-bc94-9705d14dd63a.txt', 'kimageformats': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-cc4fa8ee-e32b-4879-932b-508dea94ac2b.txt', 'knot-dns': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-8551c34b-1e1c-47a9-98d1-447b81d90951.txt', 'lark-parser': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-c6c39671-6283-422b-8576-ccbbcbe2b1bf.txt', 'leveldb': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-b4cb6eb4-1590-4f54-b4db-bbd6e591a4d4.txt', 'libavif': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-598380b0-134e-4f9d-b66e-c247316069f8.txt', 'libecc': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-3e4c485a-a6c9-4e99-a265-86951837fa6a.txt', 'librawspeed': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-ca27ef49-7f48-4d5c-bede-01232c1dda7e.txt', 'libressl': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-777bf521-bdf0-4680-8c53-9a3ba644d549.txt', 'librsvg': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-bdb5ab1b-7427-429c-83fd-2eb380f378e6.txt', 'libxml2': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-0b30f500-3355-4067-840f-bec8fc381d2e.txt', 'linkerd2-proxy': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-b720b476-4021-40d6-a462-7c2c7527ad11.txt', 'lua': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-ca500d39-e7d6-4fdc-b24e-0d507b9c8674.txt', 'mariadb-connector-j': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-bca5521d-831a-48c1-952f-e5e4883599ce.txt', 'metadata-extractor': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-8a76192b-ad97-4fb1-81d5-7b027b10b3aa.txt', 'migtd': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-40da0044-a6f9-42a9-a2b5-be0685426836.txt', 'miniz_oxide': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-cb3a88d1-14dc-4b00-8033-b16f55e35a7c.txt', 'monero': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-af36f764-dd36-4d7d-93d6-a15a637aa03a.txt', 'mp4parse-rust': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-5a2a13e3-b3be-4c69-9663-fa149e6f18ac.txt', 'mp4san': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-c62e80c9-d052-45d2-bb19-1c1511a38337.txt', 'muduo': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-42aad0e3-89e3-455f-a840-9851bab2f247.txt', 'naga': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-1b87a731-fed1-433a-99c0-39ae5ce56558.txt', 'nettle': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-743c7a22-6e77-464a-9d46-e10796508baf.txt', 'nom': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-381abbab-bf3e-4827-b1fc-a2c0395883ea.txt', 'opencv': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-1b108b51-d7d7-4da7-a99d-5df6f45c38b1.txt', 'opendal': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-642558ee-5cff-4849-8c39-6c4e1f96117e.txt', 'opensk': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-da6ae1b2-605f-427f-9e9a-f688c9113284.txt', 'openssh': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-3cd27d79-c163-425e-8852-79fc497ba7d2.txt', 'openweave': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-f8dc91ac-849f-46ec-99f6-a14b9ece42d9.txt', 'pcl': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-52606f6d-fc5a-4366-9f51-508debd5bcb7.txt', 'pest': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-2656e7d8-a76c-4411-adf0-2548aabe9ba9.txt', 'poco': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-76820bcc-7ea2-431e-8e4a-de23d60dfaec.txt', 'powerdns': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-3ec7d313-8c0d-4217-9712-817226c361c0.txt', 'prost': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-c7ed8777-670b-4fbc-b924-e422aa7a9e10.txt', 'qcms': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-170f86ed-9b76-4193-8d42-982452bbf5cf.txt', 'quick-xml': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-bb1e70d0-dbd1-4521-abbd-b52297aa881b.txt', 'redis-rs': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-22925525-4ab2-42bc-9f42-c77b1e40cfd8.txt', 'rhai': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-106f713b-c4e7-403c-a9cc-b2dbd84be3c8.txt', 'rnp': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-0da297c3-2094-431d-a262-4ce850f84289.txt', 'ron': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-aceeb418-d00f-4e4d-a8f5-8fdd626e8abd.txt', 'rust-brotli': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-53ec08a9-5380-43ed-a091-79a6eaa014f4.txt', 'rust-lexical': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-bdaa2b41-5b69-43d1-acdd-572f7ce82449.txt', 'rust-regex': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-93c802c8-90c9-4409-8e77-9d06d3376403.txt', 'rustls': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-47ecca05-126c-4234-9fb5-4097f445f688.txt', 'ryu': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-8ccb9eb7-c3d8-4e53-a656-32d1b2667632.txt', 'samba': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-4e589b67-73cf-4b5a-98ea-727dd150624e.txt', 'serde-yaml': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-7168989b-60b9-4fa5-89bd-7d1504bd7404.txt', 'serde_json': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-00bca1ea-cfad-40f6-83b2-112cf3bfabd6.txt', 'serde_urlencoded': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-6b8eb144-5780-4c04-9cc8-f6e539ba60ea.txt', 'servo': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-f6d60b1d-69ae-4ec8-8f7a-4fb183f51bc3.txt', 'solidity': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-b5f0092f-007f-49f7-bf4a-8d175378ba05.txt', 'spdm-rs': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-6518cf50-0693-457d-8f1e-d3fb3204cc1c.txt', 'starlark-rust': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-86e76fe9-e3db-446c-9cbd-4134cb809167.txt', 'suricata': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-396e8533-2023-43b9-80f2-3400b004f0a0.txt', 'swift-nio': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-fbacfa05-fd73-472c-b6ad-5e3ea94c2f1a.txt', 'swift-protobuf': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-c4edcdc1-3149-416a-af78-4819c06fd9bd.txt', 'tarantool': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-d70cee67-ef64-40a0-b236-a9d3c829e9cd.txt', 'td-shim': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-1775692b-3cae-4444-bd65-9ead786e858d.txt', 'textwrap': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-2092668b-8db4-47c2-bcac-4f53030db4e7.txt', 'tinyusb': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-6378828a-8776-478b-b951-caea354fc2cb.txt', 'tokio': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-9e01625c-cae1-4a07-8b20-067f6133aa84.txt', 'toml_edit': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-a608df9f-94d4-421a-af18-fcf9731ed8ca.txt', 'trust-dns': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-f8903117-4781-4e66-8419-80a5b95f741c.txt', 'tungstenite-rs': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-84e455af-8234-4216-b532-bff2ce0b2340.txt', 'unicode-rs': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-29bf191d-b243-4b92-9318-a84014a2cc22.txt', 'vtpm-td': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-961c540a-1a05-4fb0-9c05-c50b23a44453.txt', 'vulnerable-project': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-83ae22b8-3b3f-45dc-983c-4bdfcf7f0f57.txt', 'wasmer': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-207cbf6c-8ed7-4f77-a02f-c5230ff68b5e.txt', 'wolfssl': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-2a62acf6-6984-4e07-9a0a-66b13eb41cd4.txt', 'xnu': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-b23fb7b7-bf12-4a25-9b16-12eeb39c791b.txt', 'zeek': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-9a53b4e9-e765-4adf-9aec-e62e4366eab6.txt', 'zip-rs': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-4b3b82c0-f587-4dc6-a8ab-648cf184b187.txt', 'hive': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-185afefa-89c9-4e9c-80fa-777057a8475f.txt', 'apache-commons-imaging': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-6fcc07c5-a33a-4277-a45a-bcd088665460.txt', 'envoy': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-b01a6fe2-1743-4a2f-8bf0-273d44169f88.txt' }
alexcrichton commented 2 weeks ago

Thanks for the links! I'll start reviewing those hopefully soon.

Also I was having a tough time understanding what you were referring to before about LLVM 15 breaking. I thought that because the current coverage container was using LLVM 18 that updating it to LLVM 18.1 wouldn't be an issue because it would already be broken with LLVM 15 coverage information. Upon checking though it looks like the version in the LLVM source for profiling was "8" both with LLVM 15 and LLVM 18.0.0. The first change happened with LLVM 18.1 so that also makes more sense to me.

I'll try to dig in further to the failure logs and see what the impact of this is. Also I'll note I'm happy to rebase around other changes, so please don't block on me for anything.

maflcko commented 2 weeks ago

The failures should all be related to the raw coverage profile version in some way or another. I don't see another way other than to atomically and globally bump the coverage version for all projects and all languages. But that requires the projects to be un-pinned, and a rust-nightly bump to be combined into this pull.

My recommendation would be to change https://github.com/google/oss-fuzz/pull/12075 to nightly-2024-02-12 for now, then wait for it to land and then bump 2024-02-12 to the current date as part of this pull request.

alexcrichton commented 2 weeks ago

Ok I've gone through many of the failures and I'm sort of quite new to updating the toolchain here so I wanted to ask a few questions. I've tried to bucket all the various failure logs into a few categories:

My main question is how to handle most of these. Two action items for this PR are to update Rust in this PR and update Swift as well. Everything else though I'm less certain about. For example resolving new Clang errors will require source changes. I tested a few of the @sha256:... pinned builds and I presume they're pinned because they succeeded with Clang 15 and failed when Clang was updated to 18, and I can at least confirm they're still failing with Clang 18.1.7 as well. Should I pin all the new failures to the Clang 18 builder so the fuzzers at least still build even if coverage information is broken?

There's still other failures I don't fully understand which I'm not sure if y'all would recognize or not

alexcrichton commented 2 weeks ago

Oh and one final category of failures I forgot to mention are those that failed to build but also failed to build according to their latest status, so I ignored a few builds like that.

maflcko commented 2 weeks ago

Some arm64-related errors happened but I couldn't make heads or tails of them

They are expected, I think, and can be ignored for now, because the infra check does not spin up arm64 machines.

You can use curl 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-ca500d39-e7d6-4fdc-b24e-0d507b9c8674.txt' | tail -111 to see the tail of the (large) log only. It is the arm failure.

Two projects failed with coverage mismatches in a way I didn't understand. These weren't pinned to older containers but they also both have a custom corpus, so I don't know if that factors in here

You will have to rebase or merge with master before the trial build. Otherwise the changes (2c03690aa3849276fc00b7dff85cfb3c4b99456f) aren't picked up.

maflcko commented 2 weeks ago

If more than one project is affected by a build warning, you can soften it. For example:


diff --git a/infra/base-images/base-clang/Dockerfile b/infra/base-images/base-clang/Dockerfile
index f61b85443..c82ed1008 100644
--- a/infra/base-images/base-clang/Dockerfile
+++ b/infra/base-images/base-clang/Dockerfile
@@ -58,9 +58,9 @@ ENV CCC "clang++"
 # The implicit-function-declaration and implicit-int errors are downgraded to a
 # warning, to allow compiling legacy code.
 # See https://releases.llvm.org/16.0.0/tools/clang/docs/ReleaseNotes.html#potentially-breaking-changes
-# Same for deprecated-declarations, int-conversion,
+# Same for vla-cxx-extension, deprecated-declarations, int-conversion,
 # incompatible-function-pointer-types, enum-constexpr-conversion

-ENV CFLAGS "-O1 -fno-omit-frame-pointer -gline-tables-only -Wno-error=enum-constexpr-conversion -Wno-error=incompatible-function-pointer-types -Wno-error=int-conversion -Wno-error=deprecated-declarations -Wno-error=implicit-function-declaration -Wno-error=implicit-int -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION"
+ENV CFLAGS "-O1 -fno-omit-frame-pointer -gline-tables-only -Wno-error=enum-constexpr-conversion -Wno-error=incompatible-function-pointer-types -Wno-error=int-conversion -Wno-error=deprecated-declarations -Wno-error=vla-cxx-extension -Wno-error=implicit-function-declaration -Wno-error=implicit-int -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION"
 ENV CXXFLAGS_EXTRA "-stdlib=libc++"
 ENV CXXFLAGS "$CFLAGS $CXXFLAGS_EXTRA"
alexcrichton commented 2 weeks ago

Swift-based builds all looked to fail - I think this means that the Swift compiler needs to be updated to LLVM 18.1+ as well

Looks like Swift 5.8.1 is currently used which uses LLVM 13.0.0. The latest release of Swift is 5.10.1 which comes with LLVM 15.0.0. It looks like Swift 6 is in development but I wasn't able to find a binary to download and see if it's at the right version.

Given that I don't think there's an easy fix for Swift for now.

jonathanmetzman commented 1 week ago

/gcbrun trial_build.py all

alexcrichton commented 1 week ago

From the trial build I've categorized the failures into:

Miscellaneous failures * [rust-lexical - failed to compile with latest rustc, perhaps an LTO bug?](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-3828153e-19f4-4d3e-bb3b-deebe4adca62.txt) * [vulnerable-project - `invalid instrumentation profile data`, unclear](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-4eafc936-3426-4c25-8a1f-ff532db42ef9.txt)
Various failures in C++ projects * [envoy (use-after-poison)](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-80ed19e3-0d9e-4de1-b094-c7e81f6524bc.txt) * [leveldb (`no type named 'remove_all' in namespace 'std::filesystem'`)](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-5925e0db-95ab-4fad-99e8-5cec4151b6a9.txt) * [libphonenumber (`-Wreorder-ctor`)](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-289d012a-c57e-4bcf-b15a-8f0456b4d280.txt)
Projects that fail to compile with the latest Rust compiler * [istio-ztunnel](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-7c7d13c6-4671-4127-8e33-edd547c87e9e.txt) * [suricata](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-186ff75b-7d96-4b82-a5ff-2fcc9a4f86a4.txt) * [wasmer](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-39006676-c3a9-48b7-abeb-741a6a283176.txt)
Transient failures - OOM, out of disk, network issues, etc * [bs4](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-4854a80b-46dc-49e1-8666-04912372bea1.txt) * [django](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-528e2f18-d7f9-4b53-a61d-c87130e71898.txt) * [freeradius](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-8c71830c-29b2-4ea3-bfd0-3d42945796c3.txt) * [icu](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-ac6f7a34-5f67-4912-9f46-1d053633d54d.txt) * [lark-parser](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-113e7575-d3bb-4dad-b526-8ca080ca247f.txt) * [libpsl](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-55ccf8ee-3394-4aa7-9207-6effe80844a3.txt) * [libreoffice](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-9967e823-912c-465b-a248-19b82325e5d2.txt) * [libtasn1](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-965aa59b-e968-47d9-bcbf-f52a84b84c37.txt) * [mpv](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-ff3b86cb-4a18-46a0-8e37-36fadb76777a.txt) * [openweave](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-feb2f60b-c683-4b2b-9635-d934323d05de.txt)
Swift failures - swift older LLVM causes coverage mismatch * [grpc-swift](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-7c8fec80-1d96-41c5-9b3f-190aa4169903.txt) * [swift-nio](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-f061ed46-5725-4218-8b9b-ec75a0bb7796.txt) * [swift-protobuf](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-091c05c2-abf8-4804-b300-56866b50a60b.txt)
ARM64 failures * [lua](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-7be86ec5-f63a-4c89-a476-e1d9cfddbe21.txt) * [libxml2](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-538f5f65-86fa-446e-af4a-b7468cf0f154.txt) * [tinyusb](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-0378e20e-c661-4c9c-9197-56ff9c20d39f.txt)
Java related failures having to do with maven and network issues * [apache-commons-lang](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-de1a68ae-3b54-4fc0-888c-d5a4183199c8.txt) * [dropwizard](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-0e056bc7-4076-43a7-b4e1-074551d1ca7a.txt) * [htmlunit](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-7e901c67-8a9e-4dfd-89b6-b5784e068b6f.txt) * [jsign](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-e8ffd96b-cf6c-4b3a-8c5e-ec94dc79ba88.txt) * [json-simple](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-0c5b5bf7-8e13-4dd0-b41f-285860c152f3.txt) * [spatial4j](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-fb417380-97ec-45ff-b4ef-93c5fbd1dae7.txt) * [slf4j-api](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-02b7f1e6-f1ef-4fa6-bab7-c3a94bf4b1f2.txt) * [tablesaw](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-6b3a995c-3f17-47d9-bea1-4744d8279cce.txt) * [twelve-monkeys](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-50186b83-379c-41a3-b8ea-271b50d551a9.txt)
Failures due to `@sha256` pinning, all failed due to coverage version mismatch * [nettle](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-592be49c-1275-482f-930d-fc7ff3fa271b.txt) * [tarantool](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-20b2d881-7193-42c5-8ebd-030b82c99967.txt) * [ampproject](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-2197e989-0e71-48af-a8df-c7fcde7cb193.txt) * [knot-dns](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-4535a427-0e57-47bc-8a7e-9f1ee32b717b.txt) * [xnu](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-62cae741-bcad-4940-ac77-7295a8bfd6ef.txt) * [arrow](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-c07f7115-8a01-4388-9e4d-7de2f19743c4.txt) * [gnutls](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-11f27321-108a-4d53-8020-c39b5e23de10.txt) * [boost](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-468732fd-d67f-4820-9a6b-53d697c64a7c.txt) * [powerdns](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-bba6ca09-eccf-4467-9231-6b5449ce101e.txt) * [rnp](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-82ce1553-3397-4cf6-a617-2f64e0a70e00.txt) * [poco](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-7bd32d5b-1cef-4ad3-9b24-3fdbe8652560.txt) * [solidity](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-a137b6af-6160-4722-955e-4274ec885073.txt) * [kimageformats](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-fd071f58-d16e-4160-8dd2-4cb382d3c3d8.txt) * [opencv](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-3df644c7-c40e-4bc9-99b5-0188c819ab9a.txt) * [boost-json](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-fd7c4471-bb8b-4a3c-8120-44aef32587d3.txt) * [pcl](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-84607c9f-eb2b-4494-8561-40fd3944c724.txt) * [cryptofuzz](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-7328c065-95be-47a4-a8c6-01600e3d7ff1.txt) * [immer](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-af7b990f-dee7-42e3-8290-90028cf3a765.txt) * [monero](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-a66523c8-ff53-4960-b0a3-37d889af4381.txt) * [zeek](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-6141d3be-d86e-4127-8962-196e96dd743d.txt) * [libecc](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-b2c491f5-ad9b-486b-8ed6-47a1c6e9767f.txt) * [libressl](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-232c4817-7cc5-4f63-8956-b86252aa2a7a.txt) * [bignum-fuzzer](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-662f73ed-a712-4eeb-abde-ffc38e57fadb.txt)

Given this categorization the open questions I would have are:

maflcko commented 1 week ago

Should I remove all @sha256 pins of containers? Some will start failing to build but they're all guaranteed to have bad coverage information. Or should I add @sha256 pins for builds that are broken by this update?

I am working on unpinning them, but it will take some time.

See https://github.com/google/oss-fuzz/pulls?q=is%3Aopen+is%3Apr+author%3Amaflcko+%22Use+latest+builder%22 for the current progress.

maflcko commented 1 week ago

But yeah, I'd say to remove the pin of all projects here. This will fix a few projects, like https://github.com/google/oss-fuzz/pull/12128#issuecomment-2192485399. A few will remain broken, but those can be handled later/separately.

Also, make sure to rebase again to pick up d63f82f8e202bfa7207b562dce034927d3e6f94f.

alexcrichton commented 6 days ago

Sounds good, I've rebased, removed the one-off warning flag allowances, and removed @sha256:... pins

alexcrichton commented 6 days ago

Only envoy/samba needed new flags, looks like the other projects have updated in the meantime and no longer need a fix

jonathanmetzman commented 2 days ago

Do we need another trial build here?

maflcko commented 1 day ago

A trial build can't hurt, but I'd say that the outstanding fixes, like https://github.com/google/oss-fuzz/pull/12096 should be merged first, then this pull request should be merged or rebased with master to pick up all fixes, then a trial build should be done.

jonathanmetzman commented 1 day ago

A trial build can't hurt, but I'd say that the outstanding fixes, like #12096 should be merged first, then this pull request should be merged or rebased with master to pick up all fixes, then a trial build should be done.

OK. Let me know when this is ready for another please