search

google / oss-fuzz

OSS-Fuzz - continuous fuzzing for open source software.
https://google.github.io/oss-fuzz
Apache License 2.0
10.12k stars 2.15k forks source link

wasmer: revert rust pin #12113

Closed manunio closed 11 hours ago

manunio commented 1 week ago

Reverting rust pin as https://github.com/wasmerio/wasmer/issues/4445 has been fixed.

github-actions[bot] commented 1 week ago

manunio has previously contributed to projects/wasmer. The previous PR was #11583

maflcko commented 6 days ago

The error was (in the coverage build):

cp: cannot stat 'target/x86_64-unknown-linux-gnu/release/universal_cranelift': No such file or directory

Also, you'll have to drop the second commit (infra change).

manunio commented 6 days ago

The error was (in the coverage build):

Yes, I saw that. As you can see from the build logs, the coverage targets are building within seconds. This shouldn't be happening since projects are built from scratch for every sanitizers(address, coverage).

I was facing the same issue locally. The command build_fuzzers --sanitizer address worked fine, while the coverage was failing, so i reverted this commit deef8c5e4c9b636e731006fad651adc80606f489, and built infra images with following commands which solved coverage issue.

python3 infra/helper.py build_image --no-pull base-builder
python3 infra/helper.py build_image --no-pull base-builder-rust
python infra/helper.py build_image wasmer --no-pull
python infra/helper.py build_fuzzers --sanitizer coverage wasmer
python infra/helper.py coverage wasmer -- '-ignore-filename-regex=.*/rustc/.*'

I'm not sure what the root cause of this problem is, I saw the commit message about freezing container and reverted that, It could be related to that or something else.

maflcko commented 20 hours ago

@DavidKorczynski