search

google / oss-fuzz

OSS-Fuzz - continuous fuzzing for open source software.
https://google.github.io/oss-fuzz
Apache License 2.0
10.32k stars 2.2k forks source link

Rust build image needs updating #12410

Open silvergasp opened 2 weeks ago

silvergasp commented 2 weeks ago

There are quite a number of rust projects that are not building because they depend on the serde crate. But the serde crate requires a more up to date version of rustc (as the current version hasn't been updated since febuary). This is the error across many repositories that have failing builds.

add `#![feature(diagnostic_namespace)]` to the crate attributes to enable
Step #3 - "compile-libfuzzer-address-x86_64":     = note: this compiler was built on 2024-02-11; consider upgrading it if it is out of date
Step #3 - "compile-libfuzzer-address-x86_64": 
Step #3 - "compile-libfuzzer-address-x86_64": For more information about this error, try `rustc --explain E0658`.
Step #3 - "compile-libfuzzer-address-x86_64": The following warnings were emitted during compilation:

So far I've fixed two rounds of builds by simple updating rustc in the project specific Dockerfile e.g.

silvergasp commented 2 weeks ago

Also you appear to have a spam problem...

EDIT: There was some obviously spammy/phishy comment's earlier in the thread that I reported and appear to have been removed by the github security team.

maflcko commented 2 weeks ago

So far I've fixed two rounds of builds by simple updating rustc in the project specific Dockerfile e.g.

I haven't checked, but I think this will break their coverage build.

See also https://github.com/google/oss-fuzz/issues/11626 and https://github.com/google/oss-fuzz/pull/12365

silvergasp commented 2 weeks ago

I mean all the builds for the projects i linked are already broken. So I'm not fixing one build at the expense of another because neither the normal builds or the coverage builds are working. That being said I can see the conundrum regarding updating the image in the context of the two issues you linked.

maflcko commented 2 weeks ago

Sure, your reply and your approach makes sense. However, I think this issue is already tracked in https://github.com/google/oss-fuzz/issues/11626 and attempted to be fixed in https://github.com/google/oss-fuzz/pull/12365, so I think this one can be closed?

silvergasp commented 2 weeks ago

Hmm I think the issues you've linked are related but aren't the same issue. In fact I think the temporary workaround to the problem you've linked is what has caused the issue with building serde. So I'd say they are kind of separate and apposing issues, until both can be fixed simultaneously. Is that roughly what you are getting at i.e. you believe this issue (with building serde) would be fixed by #12365?