search

google / osv-scanner-action

https://google.github.io/osv-scanner/github-action/
Apache License 2.0
12 stars 13 forks source link

Fix configuration not found warning when using unified gh workflow #20

Closed shahar-h closed 3 months ago

shahar-h commented 4 months ago

Fixes #7 See https://github.com/google/osv-scanner-action/issues/7#issuecomment-2088054836

oliverchang commented 4 months ago

Thank you very much for the contribution! I'll defer this to @another-rex , who is still out until next week.

another-rex commented 3 months ago

I did test this change multiple different times in my own repo (https://github.com/another-rex/staging-osv-scanner-action/tree/fix-workflow-naming), and pointed another repo at it, but PRs still shows the error for some reason (https://github.com/another-rex/oss-fuzz-gen/pull/2/checks?check_run_id=24492679877).

(This run is on this PR branch: https://github.com/another-rex/oss-fuzz-gen/pull/4/checks?check_run_id=25255207554, still shows the error.)

I think it originates from the scheduled scan being skipped, which changing the name won't fix, but I'm not sure about this.

shahar-h commented 3 months ago

Tested again on my repo and it works: https://github.com/shahar-h/gateway/pull/19 https://github.com/shahar-h/gateway/pull/19/checks?check_run_id=25260222254

I noticed that your both PR branches are not rebased against main branch. Can you try to rebase them or open a new PR?