google / osv-scanner

Vulnerability scanner written in Go which uses the data provided by https://osv.dev
https://google.github.io/osv-scanner/
Apache License 2.0
6.01k stars 337 forks source link

ci: don't fail if codecov errors when uploading #1061

Closed G-Rath closed 1 week ago

G-Rath commented 1 week ago

Codecov has been just too flakey to have as a requirement for landing changes, so for the time being we're going to ignore if uploading fails

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@0bb73a6). Learn more about missing BASE report. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1061 +/- ## ======================================= Coverage ? 65.84% ======================================= Files ? 150 Lines ? 9715 Branches ? 0 ======================================= Hits ? 6397 Misses ? 2852 Partials ? 466 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

G-Rath commented 1 week ago

It looks like the underlying issues might have been resolved in the last couple of hours via https://github.com/codecov/codecov-action/issues/1487#issuecomment-2183079349, so I'm going to optimistically close this for now