Open G-Rath opened 3 months ago
Attention: Patch coverage is 84.21053%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 68.77%. Comparing base (
9fcf53f
) to head (0dbc586
).
Files with missing lines | Patch % | Lines |
---|---|---|
pkg/lockfile/parse-composer-lock.go | 84.21% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think we should try to figure out why this is generated first before merging this fix. I'm not sure if we can confidently support this before figuring out the root cause. (e.g. will the number ever have a decimal point in it?)
It seems composer
does not complain about strings and valid numbers (for example "version":20190220
or "version":1.2
) but complains about invalid numbers (for example "version":1.2.3
).
It seems it's technically possible for
composer.lock
files to have a number forversion
in packages - I can't actually reproduce this withcomposer
itself, but if I manually edit a lockfile to have a number instead of a string it doesn't complain or change the value.It would be good to understand more about how this could happen in the wild, but it's easy enough to support either way.
Resolves #1138