Closed cuixq closed 1 month ago
Attention: Patch coverage is 33.33333%
with 10 lines
in your changes missing coverage. Please review.
Project coverage is 65.78%. Comparing base (
8617d67
) to head (6462956
). Report is 5 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
internal/manifest/maven.go | 30.00% | 4 Missing and 3 partials :warning: |
internal/resolution/manifest/maven.go | 40.00% | 0 Missing and 3 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
- when merging parents, does not check parent.groupId since Maven allows this to happen;
I don't think this is quite the correct behaviour. e.g. if you say your parent's groupId is org.foo
but the parent pom says org.bar
Maven throws an error.
The problem we are seeing is that the groupId is inherited from the parent if it is missing. So we'd need to add some logic somewhere like
if proj.GroupID == "" {
proj.GroupID = parent.GroupID
}
thanks for checking that @michaelkedar !
This PR fixes two issues when reading/writing Maven manifest:
groupId
orversion
is empty, inherit these values from the parent;