Open G-Rath opened 15 hours ago
Attention: Patch coverage is 0%
with 19 lines
in your changes missing coverage. Please review.
Project coverage is 68.30%. Comparing base (
866b3e0
) to head (bb52f35
).
Files with missing lines | Patch % | Lines |
---|---|---|
pkg/osvscanner/osvscanner.go | 0.00% | 19 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
By capturing
stderr
and outputting it as an error whendocker
exits with a non-zero code, it should make it easier to catch and debug issues such as unsupported images, images that do not exist, or cannot be accessed due to lack of authentication.Currently this just assumes the output from Docker will be helpful enough since we're not able to rely on a particular structure that'd let us parse and understand the actual error, but it should still be a lot better then the current behaviour of saying the docker image was scanned with no packages being found (which we do still do as changing that would be more complex).
Because we've not got any tests for this, here's some manual testing:
Note that since we're using
r.Errorf
this also means the scanner exits with a non-zero code.Resolves #119