google / osv.dev

Open source vulnerability DB and triage service.
https://osv.dev
Apache License 2.0
1.54k stars 188 forks source link

Bioconductor enumeration code is fault-intolerant #2153

Open andrewpollock opened 6 months ago

andrewpollock commented 6 months ago

Describe the bug Bioconductor ecosystem test failures (due to the code under test being brittle) blocked unrelated PRs

Expected behaviour A degree of intermittent non-200 responses shouldn't cause immediate enumeration failure

https://requests.readthedocs.io/en/latest/user/advanced/#example-automatic-retries

Additionally, during periods of external infrastructure failure, the tests could fail open.

github-actions[bot] commented 4 months ago

This issue has not had any activity for 60 days and will be automatically closed in two weeks

andrewpollock commented 4 months ago

/cc @tylfin FYI

We authored

and haven't gotten around to addressing this yet. I wanted to ensure you were aware of this in case you/anyone else from the R Consortium have time and interest in assisting with addressing it before we get around to it.

github-actions[bot] commented 1 month ago

This issue has not had any activity for 60 days and will be automatically closed in two weeks

See https://github.com/google/osv.dev/blob/master/CONTRIBUTING.md for how to contribute a PR if you're interested in helping out.

andrewpollock commented 1 month ago

@hogo6002 can the work you did on enumeration make this code obsolete?

hogo6002 commented 1 month ago

@hogo6002 can the work you did on enumeration make this code obsolete?

I haven't replaced the API query for Bioconductor from the enumeration method to affected range comparison. If it consistently fails to enumerate versions for this ecosystem, I think we can switch to version range comparison very easily. Then, we probably won't need the enumeration code for this ecosystem.

andrewpollock commented 1 month ago

we probably won't need the enumeration code for this ecosystem

Less (fault-intolerant, in particular) code SGTM 😺