search

google / osv.dev

Open source vulnerability DB and triage service.
https://osv.dev
Apache License 2.0
1.49k stars 186 forks source link

Display the correct introduced event tooltip #2341

Closed zahraaalizadeh closed 3 months ago

zahraaalizadeh commented 3 months ago

Prior to this change, when the introduced version in the affected range was 0, the tooltip displayed: "The exact introduced commit is unknown".

This change, updates the html block to be more readable, and displays a more descriptive tooltip based on the type of the range, indicating if it has versions or commits.

resolves: https://github.com/google/osv.dev/issues/2336

Sample output for GIT range:

Screenshot 2024-06-25 at 12 31 10 PM

Sample output for other type of ranges:

Screenshot 2024-06-25 at 12 30 53 PM
another-rex commented 3 months ago

I think it's important to have the "introduced" in there, can we change the max-width in the css to make it fit on one line?

another-rex commented 3 months ago

Thanks! I think just merging in the main branch should fix the PR check.