Closed matttbe closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Code looks great, thanks. Please see the bot report on needing a CLA sign off.
@wdebruij thank you for the quick review! My administration work is now done :)
Merged. Thanks, Matthieu!
When a test is blocked and after a timeout, this Python error is produced:
That's simply because
procs
variable is an array of tuple containing 5 items. Two additional items are missing:stdout
andstderr
.With the patch, we have a clearer error:
A second commit prints more info in case of timeout if we are in verbose with
log_on_error
option.