google-cla[bot]
commented
3 years ago Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
fw-strlen
Makes no difference for upstream packetdrill, but this makes the mptcp-fork 'join' tests work when run from the run_all script.
The mp_join tests add a secondary ip address. Without the netmask the kernel can't find a route for the syn/ack packet and the tcp syn carrying the join request never gets a response.
The netmasks are the ones used in the two DEFAULT_V{4,6}_LIVE_REMOTE_IP_STRING defines.
The basic-v{4,6} test cases are adjusted to add a host-specific route rather than attempt to change a (now no longer existing) entry.