google / packetdrill

The official Google release of packetdrill
GNU General Public License v2.0
887 stars 220 forks source link

gtests: net: packetdrill: run_all: make print python3+ compatible #49

Closed roxell closed 3 years ago

roxell commented 3 years ago

When python3 is used, this syntax error about 'missing parentheses' shows up:

File \". packetdrill run_all.py\", line 114 print 'stdout: ' ^ SyntaxError: Missing parentheses in call to 'print'. Did you mean print'stdout: '?

Rework the patch by adding parentheses to the print(...) funciton.

Signed-off-by: Anders Roxell anders.roxell@linaro.org

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

roxell commented 3 years ago

@googlebot I signed it!

nealcardwell commented 3 years ago

Thanks for this. Looks pretty good. Two quick things:

gtests: net: packetdrill: run_all: make print python3+ compatible

For consistency with previous changes, can you please use something like:

packetdrill: run_all: make print python3+ compatible

Rework the patch by adding parentheses to the print(...) funciton.

typo: s/funciton/function/

roxell commented 3 years ago

@nealcardwell , thank you for the review.

updated those things.

nealcardwell commented 3 years ago

The commits at https://github.com/google/packetdrill/pull/49/commits do not seem to show your updates yet?

roxell commented 3 years ago

@nealcardwell urgh, I found the bug behind the keyboard... updated now. =)