Closed roxell closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Thanks for this. Looks pretty good. Two quick things:
gtests: net: packetdrill: run_all: make print python3+ compatible
For consistency with previous changes, can you please use something like:
packetdrill: run_all: make print python3+ compatible
Rework the patch by adding parentheses to the print(...) funciton.
typo: s/funciton/function/
@nealcardwell , thank you for the review.
updated those things.
The commits at https://github.com/google/packetdrill/pull/49/commits do not seem to show your updates yet?
@nealcardwell urgh, I found the bug behind the keyboard... updated now. =)
When python3 is used, this syntax error about 'missing parentheses' shows up:
File \". packetdrill run_all.py\", line 114 print 'stdout: ' ^ SyntaxError: Missing parentheses in call to 'print'. Did you mean print'stdout: '?
Rework the patch by adding parentheses to the print(...) funciton.
Signed-off-by: Anders Roxell anders.roxell@linaro.org