google / packetdrill

The official Google release of packetdrill
GNU General Public License v2.0
897 stars 221 forks source link

net-test: packetdrill: run_all: add timeout flag #54

Closed tannerlove closed 3 years ago

tannerlove commented 3 years ago

Enable passing a custom timeout value to run_all.py. If unspecified, the default remains 180.

Tested: on kernel netdev-netnext/master HEAD at commit 5e437416ff669 (1) verify default timeout remains 180: $ python ./packetdrill/run_all.py -S -v -L -l tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt OK [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv4)] stdout: stderr: OK [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv6)] stdout: stderr: OK [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv4-mapped-v6)] stdout: stderr: Ran 3 tests: 3 passing, 0 failing, 0 timed out (3.83 sec): tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (2) verify -t 0 results in timeout: python ./packetdrill/run_all.py -S -v -L -l -t 0 tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt KILL [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv4)] stdout: stderr: KILL [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv4-mapped-v6)] stdout: stderr: KILL [/export/hda3/tmp/tannerlove/net/tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt (ipv6)] stdout: stderr: Ran 3 tests: 0 passing, 0 failing, 3 timed out (1.85 sec): tcp/mss/mss-getsockopt-tcp_maxseg-server.pkt

Signed-off-by: Tanner Love tannerlove@google.com

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

tannerlove commented 3 years ago

@googlebot I signed it!