google / packetdrill

The official Google release of packetdrill
GNU General Public License v2.0
887 stars 220 forks source link

Execute testcase tcp/blocking/blocking-write.pkt failed #58

Closed Bubble-mt closed 2 years ago

Bubble-mt commented 2 years ago

Execute testcase packetdrill/gtests/net/tcp/blocking/blocking-write.pkt by packetdrill failed, command as below: ../../packetdrill/packetdrill blocking-write.pkt

1632466747(1)

The temp file didn't remove.

1632466778(1)
nealcardwell commented 2 years ago

Hi,

It looks like perhaps in your copy of blocking-write.pkt you have removed the line:

../common/set_sysctls.py /proc/sys/net/ipv4/tcp_min_tso_segs=10

Is that so?

If that is not the issue, then can you please share the output of the following commands, so we can see exactly which version of the scripts you are using, and what OS distribution and kernel:

git remote -v | grep packetdrill git log --oneline | head -2 cat /etc/lsb-release uname -r

Thanks!

neal

On Fri, Sep 24, 2021 at 3:00 AM Bubble-mt @.***> wrote:

Execute testcase packetdrill/gtests/net/tcp/blocking/blocking-write.pkt by packetdrill failed, command as below: ../../packetdrill/packetdrill blocking-write.pkt [image: 1632466747(1)] https://user-images.githubusercontent.com/72586297/134631845-02594cbf-e145-485e-b82b-f509251140b6.png

The temp file didn't remove. [image: 1632466778(1)] https://user-images.githubusercontent.com/72586297/134631924-3c5554bc-9473-4cc6-89dc-9fa6efe3fa9e.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/packetdrill/issues/58, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZHSHKNX3EADYXKWALBPE3UDQOXBANCNFSM5EVI2NNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Bubble-mt commented 2 years ago

Hi Neal,

I didn't remove the line. Below is the verbose output of command.

1632618650(1)

Below are git version, OS distribution and kernel:

1632618749(1)

BTW, I found if I add a blank link. `../common/defaults.sh ../common/set_sysctls.py /proc/sys/net/ipv4/tcp_min_tso_segs=10

` I could execute the script succeed.

580cd8cb419784929e9bc9cb2dcfb68
nealcardwell commented 2 years ago

The blocking-write.pkt script works for me as-is with an Ubuntu 20.04 machine with a kernel based on v5.13.12. I'm not sure why it's not working in your environment. If you are able to find a root cause, please feel free to submit a patch. Thanks!

neal

On Sat, Sep 25, 2021 at 9:17 PM Bubble-mt @.***> wrote:

Hi Neal,

I didn't remove the line. Below is the verbose output of command. [image: 1632618650(1)] https://user-images.githubusercontent.com/72586297/134789741-acb9f0c0-8640-4a37-a905-ce9fc36cae0a.png

Below are git version, OS distribution and kernel: [image: 1632618749(1)] https://user-images.githubusercontent.com/72586297/134789768-77c40ddb-3ca0-4187-97e2-12b9e7dfd915.png

BTW, I found if I add a blank link. `../common/defaults.sh ../common/set_sysctls.py /proc/sys/net/ipv4/tcp_min_tso_segs=10

` I could execute the script succeed. [image: 580cd8cb419784929e9bc9cb2dcfb68] https://user-images.githubusercontent.com/72586297/134789851-df8ccd30-3f32-463a-9275-40c03f14203a.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/google/packetdrill/issues/58#issuecomment-927207964, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZHSHOGSPUCSWEO43WCFFLUDZYBXANCNFSM5EVI2NNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.