google / packetdrill

The official Google release of packetdrill
GNU General Public License v2.0
897 stars 221 forks source link

net-test: packetdrill: Remove TUN_F_UFO from offload flags #6

Closed ghost closed 6 years ago

ghost commented 6 years ago

Commit d591a1f3aad92ade4642e4173f4c368006c27f0f in the Linux kernel removed handling of the TUN_F_UFO flag in the set_offload() function for tun devices (in net/tun.c).

Because of this, when TUN_F_UFO (0x10) is set in the argument for an ioctl(..., TUNSETOFFLOAD, ...) call on a tun device, an error will be indicated, with errno set to EINVAL.

The output of packdrill in this case looks like this:

TUNSETOFFLOAD: Invalid argument

This change removes the TUN_F_UFO flag from the argument in order to avoid this problem.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.