google / packetdrill

The official Google release of packetdrill
GNU General Public License v2.0
897 stars 221 forks source link

Check accepted fd instead of listen fd? #70

Open tanjianfeng opened 1 year ago

tanjianfeng commented 1 year ago

Is this a typo or deliberate? This line checked the listen fd (3), instead of accepted fd (4)?

https://github.com/google/packetdrill/blob/master/gtests/net/tcp/inq/server.pkt#L50

I guess the original purpose is to check this?

+0 read(4, ..., 2000) = 0

nealcardwell commented 1 year ago

Thanks for the report! We'll try to fix this. Or please feel free to post a patch. Thanks!