Closed johnpryan closed 5 years ago
Hi John, thanks for raising this PR. I've had to fix some travis configurations, so your PR is regularly failing until you sync again. Rather than having another back-and-forth over a one-line change, I've just submitted your change: #190
Thanks!
For the record - the absence of a direct import
to a package does not necessarily mean there should not be a dependency.
Any package with a build.yaml
file should have a dependency on the build_config
package. This is described here: https://github.com/dart-lang/build/tree/9a8ac4bfa883ebc5cf2bc3f76b6bf1393bcb9a46/build_config#publishing-buildyaml-files
Thanks for clarifying @natebosch, that makes sense.
package:build_config doesn't seem to be used directly by this package. This causes issues when packages using package:pageloader need to use a newer version of build_runner, for example: