search

google / pageloader

A framework for creating page objects for in-browser or WebDriver tests.
https://pub.dartlang.org/packages/pageloader
Apache License 2.0
40 stars 46 forks source link

remove direct dependency on package:build_config #188

Closed johnpryan closed 5 years ago

johnpryan commented 5 years ago

package:build_config doesn't seem to be used directly by this package. This causes issues when packages using package:pageloader need to use a newer version of build_runner, for example:

dependencies:
  build_runner: ^1.6.0
  pageloader: ^3.0.0
Because pageloader >=3.0.0 depends on build_config ^0.3.1 and build_runner >=1.3.4 depends on build_config >=0.4.0 <0.4.1, pageloader >=3.0.0 is incompatible with build_runner >=1.3.4.
mk13 commented 5 years ago

Hi John, thanks for raising this PR. I've had to fix some travis configurations, so your PR is regularly failing until you sync again. Rather than having another back-and-forth over a one-line change, I've just submitted your change: #190

Thanks!

natebosch commented 5 years ago

For the record - the absence of a direct import to a package does not necessarily mean there should not be a dependency.

Any package with a build.yaml file should have a dependency on the build_config package. This is described here: https://github.com/dart-lang/build/tree/9a8ac4bfa883ebc5cf2bc3f76b6bf1393bcb9a46/build_config#publishing-buildyaml-files

johnpryan commented 5 years ago

Thanks for clarifying @natebosch, that makes sense.