Set version range for `build_config`

hpoit commented 5 years ago

As recommended by Nate Bosch.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

hpoit commented 5 years ago

@googlebot I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

natebosch commented 5 years ago

@mk13 can you review?

@hpoit - can you fix the bad merge in the description section?

mk13 commented 5 years ago

Let me know if you want me to merge this as soon as Travis is finished.

hpoit commented 5 years ago

Hello, I still get the following:

environment:
  sdk: '>=2.0.0 <3.0.0'

dependencies:
  angular: ^5.0.0
  angular_forms: ^2.0.0
  angular_router: ^2.0.0-alpha+19
  http: ^0.11.0
  stream_transform: ^0.0.6

dev_dependencies:
  angular_test: ^2.0.0
  build_runner: ^1.6.5
  build_test: ^0.10.2
  build_web_compilers: '>=1.2.0 <3.0.0'
  mockito: ^3.0.0-beta+1
  pageloader: ^3.2.0
  test: ^1.0.0

dependency_override:
  build_config: ^0.4.0

Working dir: /Users/john/WebstormProjects/toh-6-master
/usr/local/Cellar/dart/2.5.0-dev.1.0/bin/pub get
Resolving dependencies...
Because no versions of pageloader match >3.2.0 <4.0.0 and pageloader 3.2.0 depends on build_config ^0.3.1, pageloader ^3.2.0 requires build_config ^0.3.1.
And because build_runner >=1.6.5 depends on build_config >=0.4.1 <0.4.2, pageloader ^3.2.0 is incompatible with build_runner >=1.6.5.
So, because angular_tour_of_heroes depends on both build_runner ^1.6.5 and pageloader ^3.2.0, version solving failed.
Process finished with exit code 1

hpoit commented 5 years ago

@mk13 the build is failing

natebosch commented 5 years ago

@hpoit - the package hasn't been published yet. Someone needs to bump the pubspec version and add a changelog entry, then publish.

https://pub.dev/packages/pageloader still shows 3.2.0

@mk13 - will you be able to publish?

hpoit commented 5 years ago

Thanks @natebosch, @mk13, @jakemac53. As soon as it's published I'll try using it!

mk13 commented 5 years ago

Published 3.2.1 with this change.

hpoit commented 5 years ago

Thanks Max. How come the build is still failing?

natebosch commented 5 years ago

@hpoit if the error is different from before this isn't the appropriate place to debug.

The discussion leading to this change was a version solve.

In either case your question is too vague to be actionable. Please try gitter or stack overflow and include more details.

mk13 commented 5 years ago

@hpoit

The "build failing" icon on pub is just indicative of the chrome driver vs. chrome versioning I mentioned in PR #193 . I've tried resolving it yesterday directly but looks like I'll have to do some additional adjustments in relation to webdriver package to fix that. 3.2.1 should unblock you if your issue is the version range on build_config.

google / pageloader