Travis CI: Add Python 3.7

google / pasta

Library to refactor python code through AST manipulation.

Apache License 2.0

341 stars 40 forks source link

Travis CI: Add Python 3.7 #73

Closed cclauss closed 3 years ago

cclauss commented 5 years ago

https://devguide.python.org/devcycle/#end-of-life-branches Python 3.4 is end of life this codebase really need to continue to support it?

soupytwist commented 5 years ago

Thank you!

We should generate the golden data for 3.7 rather than ignore failures for it. Would you do that in this PR?

python3.7 setup.py test -s pasta.base.annotate_test.generate_goldens

will create a starting point for 3.7.

As for 3.4, if ti becomes much work to maintain I'll consider dropping support for it. For now I don't think it's a big issue.

soupytwist commented 5 years ago

Hi @cclauss ,

What I meant was to run the generate_goldens command and add the files which are created to this commit (should be 30-40 files created in testdata/ast/golden/3.7). Add it as a before_script defeats the purpose of the test, since it would generate the expectation from the same code which is under test.

soupytwist commented 3 years ago

3.7 and 3.8 are included in travis build now.