Not populated in HTML - Githubissues

google / pcbdl

PCB Design Language: A programming way to design schematics.

Other

155 stars 23 forks source link

Not populated in HTML #2

Closed kiavash-at-work closed 5 years ago

kiavash-at-work commented 5 years ago

When the part is not populated, the generated HTML should mention "Do Not Populate!"

--- a/pcbdl/html.py
+++ b/pcbdl/html.py
@@ -63,9 +63,13 @@ class HTMLPart(Plugin):

                if part.__doc__:
                        yield "<pre>%s</pre>" % textwrap.dedent(part.__doc__.rstrip())

                yield "<p>Value: %s</p>" % part.value
-               yield "<p>Part Number: %s</p>" % part.part_number
+
+               if part.populated:
+                       yield "<p>Part Number: %s</p>" % part.part_number
+               else:
+                       yield "<p>Do Not Populate!</p>"

amstan commented 5 years ago

Per in person conversation:

Part number will remain regardless, just in case one wants to see what part number they have the option of populating and also to encourage people to put a real part number for potential things instead of "DNS".
What I really want is the whole part in the html to maybe turn gray when "not part.populated".