search

google / pcbdl

PCB Design Language: A programming way to design schematics.
Other
155 stars 23 forks source link

Make autoname work without file argument #23

Closed kasbah closed 4 years ago

kasbah commented 4 years ago

This confused me when going through the example from readme so I fixed it.

amstan commented 4 years ago

:O Welcome! Thanks for taking a look!

fixup: context: Allow empty filename for autoname

Well, that's embarrassing, I hate when I break the Readme tutorial stuff. It's because the interactive shell is slightly different than the normal intended way to run circuits (1000 net projects). I actually fixed it the other day in another branch (https://github.com/google/pcbdl/commit/83843aedae4d7d173f88aab90fe947535ef1b922#diff-b094dc28ef16a732b464d19cca6500c3), didn't realize the implications. Grabbed the change and made a new commit for it.

Thanks for the pull requests, cherry-picked!