google / peoplemath

Web application for team planning
Apache License 2.0
127 stars 36 forks source link

Error swallowing in auth.interceptor.ts #136

Open m-s-sh opened 3 years ago

m-s-sh commented 3 years ago

https://github.com/google/peoplemath/blob/7e6d8a6695e1f9aa39cb25375a41056c8f627694/src/app/services/auth.interceptor.ts#L61

All non authentication errors are swallowed by the code above.

I think it needs to be changed to

return throwError(err);

because

of(err)

'eats' the error context, which bypass error checking in all layers above and catchError code, stops working.