google / peoplemath

Web application for team planning
Apache License 2.0
126 stars 34 forks source link

Use newer npm version in continuous build #140

Closed amdw closed 3 years ago

amdw commented 3 years ago

Currently the continuous build is giving WARN EBADENGINE warnings at the npm install stage, complaining that various Angular packages require a newer npm version.

The build image is based on Debian testing, which currently has npm 7.5.2, but these packages apparently require at least 7.5.6.

https://packages.debian.org/bullseye/npm

This doesn't seem to be actively breaking anything, so it's probably OK to just wait for Debian testing to get at least this npm version, then build a new base image.

The package-lock.json file was generated using npm 7.5.2, so we should maybe consider recreating that using a newer version as well, when available.

amdw commented 3 years ago

This commit addresses the build errors.

I tried recreating package-lock.json, but I got some resolution errors stemming from indirect dependencies of firebase. I'll take a look at these separately.