search

google / peoplemath

Web application for team planning
Apache License 2.0
125 stars 34 forks source link

Switch to modular AngularFire APIs #173

Open amdw opened 2 years ago

amdw commented 2 years ago

There's a new modular version of Firebase available - upgrade instructions here:

https://firebase.google.com/docs/web/modular-upgrade

This should also enable upgrading to 7.x.x of @angular/fire:

https://github.com/angular/angularfire/blob/master/docs/version-7-upgrade.md

amdw commented 2 years ago

Looking further, I'm not sure that right now is the optimal time to make this upgrade. I was able to make the application compile with the compat APIs (#174) but I wasn't able to make it work with the switch to the modular style, which IIUC is actually the part of this that brings the significant benefits (tree-shaking reducing file sizes etc).

The @angular/fire docs currently have a fairly recent warning saying that it may not be possible to move past the compat style at this stage:

https://github.com/angular/angularfire/blame/27889806b87f5bcff028561d392b4d80824fdd1b/docs/version-7-upgrade.md#L21

Overall these APIs look quite new, and it may be worth waiting a little while for them to settle down before trying to upgrade.

amdw commented 2 years ago

The basic upgrade was done in 877e38ac89ce548177d485b1c573dece035cf87c. I'll leave this bug open for a potential future switch to the modular style APIs (which still don't seem to be ready according to the documentation).