google / perfetto

Performance instrumentation and tracing for Android, Linux and Chrome (read-only mirror of https://android.googlesource.com/platform/external/perfetto/)
https://www.perfetto.dev
Apache License 2.0
2.73k stars 341 forks source link

Perfetto is crashed #791

Closed miraclemore closed 3 months ago

miraclemore commented 3 months ago

After update to perfetto version v44,some move behavior trigger crash

Pls refer to the below steps to reproduce.

  1. open any trace file.
  2. move any track row before CPU0 task row

Logs: UI: https://ui.perfetto.dev/v44.0-c7da51a07

Error: Failed assertion

Trace: not available (FILE). Provide repro steps. UA: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36 Referrer:

LalitMaganti commented 3 months ago

I can repro this on stable and autopush. Specifically, a thread/process scoped track needs to be drag-dropped in to the global section. There's a big delay followed by the crash.

Filed b/341429501 to track internally.

miraclemore commented 3 months ago

Yeah, whatever stable or autopush, both will crash if u drag the track to the first one. Is there any temporay method to work around that ? @LalitMaganti

LalitMaganti commented 3 months ago

Not that I'm aware of apart from just not dragging the track.

stevegolton commented 3 months ago

Can repro, will take a look. Probably a good candidate for cherry picking once we find a fix

stevegolton commented 3 months ago

Fixed in https://android-review.googlesource.com/c/platform/external/perfetto/+/3092242 which has landed and is available on the autopush channel.