Closed balazsgrill closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Sorry for the delay. I can't approve because both the CLA checker and Travis failed. For the CLA checker, see the instructions above.
For travis, if you click through, you'll end up on https://travis-ci.org/google/periph/jobs/653761040 and scrolling a bit you'll find the red text:
Check Code is well formatted
The command "if [[ $TRAVIS_GO_VERSION != 1.7.6 ]]; then echo 'Check Code is well formatted'; ! gofmt -s -d . | read; fi" exited with 1.
Basically, run gofmt -s on the new files and it should do a small number of modifications.
@googlebot I signed it!
Merging #433 into master will decrease coverage by
0.14%
. The diff coverage is55.04%
.
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 63.51% 63.36% -0.15%
==========================================
Files 117 120 +3
Lines 12187 12425 +238
==========================================
+ Hits 7740 7873 +133
- Misses 4249 4344 +95
- Partials 198 208 +10
Impacted Files | Coverage Δ | |
---|---|---|
experimental/devices/mcp23xxx/pins.go | 33.33% <33.33%> (ø) |
|
experimental/devices/mcp23xxx/mcp23xxx.go | 54.8% <54.8%> (ø) |
|
experimental/devices/mcp23xxx/registers.go | 92% <92%> (ø) |
|
devices/lepton/lepton.go | 88.41% <0%> (+1.21%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3b7d83e...0c17bcc. Read the comment docs.
gohci
Could you fix some of the comments? In practice the copyright one is the one I care the most about.
gohci
Thanks!
This driver supports the following I2C and SPI IO extenders:
The driver is still under development, Interrupt support is not yet implemented.