google / periph

Older version of periph, see new version at https://github.com/periph
https://periph.io
Apache License 2.0
1.75k stars 167 forks source link

ssd1306: Made column differential work for SSD1306 #444

Closed wyvernzora closed 4 years ago

wyvernzora commented 4 years ago

I changed ssd1306 driver to write page-by-page, and made column differential work without corrupting screen. This change is also preparation for sh1106 support, which I have working locally and plan to contribute in the future.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

codecov-commenter commented 4 years ago

Codecov Report

Merging #444 into master will decrease coverage by 0.0%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #444     +/-   ##
========================================
- Coverage    63.1%   63.1%   -0.0%     
========================================
  Files         125     125             
  Lines       12721   12739     +18     
========================================
+ Hits         8028    8034      +6     
- Misses       4470    4478      +8     
- Partials      223     227      +4     
Impacted Files Coverage Δ
src/periph.io/x/periph/devices/ssd1306/ssd1306.go 95.5% <0.0%> (-4.5%) :arrow_down:
...rc/periph.io/x/periph/host/sysfs/thermal_sensor.go 81.5% <0.0%> (-2.3%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d928bc5...53bdf6e. Read the comment docs.

wyvernzora commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

maruel commented 4 years ago

gohci

maruel commented 4 years ago

Cool thanks! It's going to be a small tad slower but I guess it's going to be fine.