Migrate from mox to mock library

google / personfinder

Person Finder is a searchable missing person database written in Python and hosted on App Engine.

https://google.org/personfinder

Apache License 2.0

530 stars 196 forks source link

Migrate from mox to mock library #490

Open nworden opened 5 years ago

nworden commented 5 years ago

mox is a mocking library that hasn't been updated in a long time: https://pypi.org/project/mox/ we use it for test_tasks, test_external_search, and test_send_mail.

Python has a new library simply called mock, which is built-in for Python 3 and available for Python 2 as a library.

nworden commented 5 years ago

It turns out everything else we use mox for is related to AppEngine APIs, which we have to get rid of anyway. It doesn't make a lot of sense to migrate tests that are going to need to be rewritten anyway, so I'm marking this blocked (once we rewrite those tests with Cloud APIs or whatever, we can remove mox.py and close this).