google / personfinder

Person Finder is a searchable missing person database written in Python and hosted on App Engine.
https://google.org/personfinder
Apache License 2.0
533 stars 194 forks source link

flake8 is missing and thus no unit tests run #762

Closed ryosuketc closed 4 years ago

ryosuketc commented 4 years ago

Unit tests failed to run because of the lack of flake8 It does not seem to be specified neither in GettingStarted nor requirements.txt.

For me, I just installed it in my global directory (i.e. pip install flake8), which worked fine. I am wondering if above is the right way, or should I install it in app/vendors by specifying it in requirements.txt?

Probably only a few usage of flake8 is at setup.cfg. If I am not mistaken, it is referring to the global one (vs. app/vendors?)

$ tools/all_tests
No config file found, using default configuration
--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
/usr/bin/python: No module named flake8
$ pip install flake8 # Successfully installed flake8-3.8.4
ryosuketc commented 4 years ago

Fixed in the latest GettingStarted - made a typo and fixed it. https://github.com/google/personfinder/wiki/GettingStarted/_compare/84b9d1da610a54fd1d1e7d6c93dca4873c139308 https://github.com/google/personfinder/wiki/GettingStarted/_compare/a81c4d55431fe8649ba6e63feb233109c1163313 @gimite FYI