Fix slow server tests #763 #764

google / personfinder

Person Finder is a searchable missing person database written in Python and hosted on App Engine.

https://google.org/personfinder

Apache License 2.0

533 stars 194 forks source link

Fix slow server tests #763 #764 #765

Closed ryosuketc closed 3 years ago

ryosuketc commented 4 years ago

Optimize server tests. The PR also includes a small fix to support virtualenv.

Support an optional argument --skip_update_translations #763
Skip app/vendors from compilemessages #763
Add venv/ to .gitignore to support virtualenv #764

Example usage and outputs:

 % tools/server_tests --skip_update_translations
--- Skipped updating translations

--- Running server tests
... (server tests continue) ...

 % tools/server_tests                                                                                       

--- Updating translations
... (update translations) ...

--- Running server tests
... (server tests continue) ...

ryosuketc commented 4 years ago

It is OK this time (especially since the PR is still small), but it is generally recommended to keep a PR small so that a single PR does a single thing (e.g., resolving a single issue) rather than combining multiple independent changes to a single PR.

Thank you for the feedback. Indeed I used different branches to make the changes but I thought they were too small for multiple PRs... I learn that a PR could never be too small. Appreciated.

ryosuketc commented 4 years ago

Mentioned in https://github.com/google/personfinder/issues/764 as well but it might be worth noting here in the PR itself too:

This code passes all tests except for:
- Python 3 unit tests
- (server tests) the image-related ones, which we can disregard for now as chatted offline with @gimite (with future migration to Python 3 etc in mind).

gimite commented 3 years ago

LGTM. Merged. Thanks!

ryosuketc commented 3 years ago

Send as a new PR. https://github.com/google/personfinder/pull/768