search

google / personfinder

Person Finder is a searchable missing person database written in Python and hosted on App Engine.
https://google.org/personfinder
Apache License 2.0
533 stars 194 forks source link

Revert --ignore=vendors in compilemessages due to version compatibility #767

Closed ryosuketc closed 3 years ago

ryosuketc commented 3 years ago

This reverts commit 0af534c.

--ignore option for compilemessages is supported in greater than django 3.0. https://docs.djangoproject.com/en/3.1/ref/django-admin/#cmdoption-compilemessages-ignore

makemessages support --ignore even on django 1.x https://docs.djangoproject.com/en/3.1/ref/django-admin/#cmdoption-makemessages-ignore

Indeed, our django version is 1.11.29, which is the last version for Python 2.x Django 1.11 is the last version to support Python 2.7. Support for Python 2.7 and Django 1.11 ends in 2020. https://docs.djangoproject.com/en/3.1/faq/install/

As a result of adding the option to compilemessages, tools/update_messages started to faild with exit code of 2. Based on an internal sync, we decided to keep the change on hold until we migrate the project to Python 3 (and consequently migrate django to 3.x as well).

ryosuketc commented 3 years ago

I included changes previously merged by mistaken. I will file another PR.