google / physical-web

The Physical Web: walk up and use anything
http://physical-web.org
Apache License 2.0
5.99k stars 665 forks source link

duplicate nearby notifications for a beacon when using a forwarder #781

Closed ferencbrachmann closed 8 years ago

ferencbrachmann commented 8 years ago

One of our clients had the following issue:

The URL encoded on the beacon: https://beeem.co/em000004

The attached screenshot shows that the cached "old" final URL and the "new" final URL are both displayed.

screenshot_20160817-170352

kevinahuber commented 8 years ago

Could related to #739 (Caching of Nearby URLs)

It currently caches on the broadcast URL, but also on redirects. So it's not treating one broadcast URL as one beacon with one destination, with no way to bust this behavior (currently).

scottjenson commented 8 years ago

Let me check. Get back to you in a bit...

scottjenson commented 8 years ago

This is a bug that will be fixed with the next release of Play Services. However, note this bug only affects attachments to UID beacons, not Eddystone-URL beacons.

ferencbrachmann commented 8 years ago

Dear Scott, this is an Eddystone URL beacon. We did identify the issue you're refering to also but that's not the bug in this case.

scottjenson commented 8 years ago

OK, sorry. I went back to the Nearby team and they confirmed that this will also affect Eddystone-URL as well (The original bug I reviewed only discussed the attachment). They feel that both of these will be fixed with new GPS release coming in a few weeks.

ferencbrachmann commented 8 years ago

Has this promised GPS update been launched? I still got a duplicate notification a few days ago.

scottjenson commented 8 years ago

It is still there and in the pipeline. There is a rather nasty (unrelated bug) in Nearby that has shown up and is slowing everything down I'm afraid. The fix is going to be delayed until the next push 8 weeks later.

I'm very sorry for that. We're working as hard as we can to get this out there.