search

google / physical-web

The Physical Web: walk up and use anything
http://physical-web.org
Apache License 2.0
5.99k stars 665 forks source link

Added the exceptions on jsons in PhysicalWebCollection #818

Closed RajPratim21 closed 8 years ago

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

cco3 commented 8 years ago

Is your change properly rebased on master? Did you mean to add files?

RajPratim21 commented 8 years ago

During the initial setup src/java files can't find the files in the folder lib: so I also moved pwsCollections from lib/org.pws.collections to app/main/org.physical.web/collections

googlebot commented 8 years ago

CLAs look good, thanks!

cco3 commented 8 years ago

Are you trying to develop in android studio? We've had trouble getting the library set up correctly in studio. Just build from the command line, e.g., adb installDebug

Anyway, you are going to have to put the library back where it's supposed to be.

RajPratim21 commented 8 years ago

Yes I was building with android studio

RajPratim21 commented 8 years ago

I have a query It seems to works with the libs under the src\main in my system can't it be done like this? I am a novice so I am apologizing for the naive comments though.

cco3 commented 8 years ago

We have this code separated out into a distinct library so that it can be used by itself. We don't want to move that library under the directory for the app.

cco3 commented 8 years ago

Closing due to inactivity. Please let me know if you wish to pursue this.