search

google / physical-web

The Physical Web: walk up and use anything
http://physical-web.org
Apache License 2.0
6k stars 665 forks source link

Gzip fat beacon #877

Closed iankchristie closed 7 years ago

iankchristie commented 7 years ago

@cco3 made fix for GZIP_MAGIC. Not using the descriptor anymore

cco3 commented 7 years ago

Looks OK. Please squash.

iankchristie commented 7 years ago

@cco3 squashed

iankchristie commented 7 years ago

@cco3 squashed everything

cco3 commented 7 years ago

LGTM, but let's have Matt look at it first.

iankchristie commented 7 years ago

@cco3 @nondebug hey hey, nice catch Matt. We didn't need that functionality since we aren't changing the underlying file with the stream. It's been fixed

nondebug commented 7 years ago

lgtm

cco3 commented 7 years ago

You need to rebase on master.

cco3 commented 7 years ago

Also, for the commit message, don't use a full stop on the subject line. Please use full sentences in the message body.

cco3 commented 7 years ago

You forgot to update the commit message.

iankchristie commented 7 years ago

@cco3 how does it look now?