google / physical-web

The Physical Web: walk up and use anything
http://physical-web.org
Apache License 2.0
6k stars 665 forks source link

Omnibox issues in Chrome for iOS 55 #878

Closed ferencbrachmann closed 7 years ago

ferencbrachmann commented 7 years ago

Hey, I have a few screenshots that outline the issue: validated beacon URLs showing up in the widget (and on an Android device as well) but not in the omnibox. 2017-01-12 11 30 57 2017-01-12 11 31 05 2017-01-12 11 31 16 2017-01-12 10 31 28

ferencbrachmann commented 7 years ago

2017-01-12 12 00 27

scottjenson commented 7 years ago

OK, so I have to ask a couple of (obvious) questions, sorry 1) Did you restart Chrome? 2) Do you have "Location" turned on? (You can see this in Settings>Chrome>Privacy

Chrome asks when you first boot Chrome to use location. Most people say yes but if you've said no, we respect that you don't want to give up your location so don't scan.

ferencbrachmann commented 7 years ago

Issue found: even though I have the flags turned on there seems to be a PW setting turned off for some reason. But can not change the settings as the screen becomes dead after I tap on "physical web". Could this have something to do with the fact that this is a WiFi (only) iPad? (no GPS module)

2017-01-12 21 47 27

scottjenson commented 7 years ago

Location isn't about only GPS it's about implied location. As a URL can be coded, it could give away your location, which is why we have to respect the location flag. I'll ask @nondebug to comment on what may be happening on the crash

nondebug commented 7 years ago

Hi Ferenc, I couldn't repro the crash (using an iPhone 6s) but there are some known UI bugs in the Physical Web preferences page in Chrome 55 that could be causing a crash on some devices. Which iPad model are you using?

I think this particular bug is fixed in Chrome 56. If you get a chance, could you sign up for the Chrome Beta FlightTest and see if you can access the prefs page?

ferencbrachmann commented 7 years ago

@nondebug iPad mini 2

ferencbrachmann commented 7 years ago

@scottjenson @nondebug The issues with the settings UI are all gone in Chrome 65 Beta but the beacons don't show up in the OmniBox as they do on the 4 iPhones I could test. All good inside the widget by the way so I'm certain something is wrong here.

nondebug commented 7 years ago

Thanks! Could you also check chrome://physical-web?

ferencbrachmann commented 7 years ago

The issue went away after visiting chrome://physical-web ...it displayed the beacon in question BTW