search

google / physical-web

The Physical Web: walk up and use anything
http://physical-web.org
Apache License 2.0
6k stars 665 forks source link

Cleanup: Remove mDisplayUrl from PhysicalWebBroadcastService #884

Closed cco3 closed 7 years ago

cco3 commented 7 years ago

It's not really needed as a field.

cco3 commented 7 years ago

(You can either do this in the current change you are working on or later)

iankchristie commented 7 years ago

@cco3 I'm not sure how to get around this problem:

The advertisingcallback for notifications needs to know the url to display. However, I can't pass it in as a parameter because the method signature is overridden. I think the displayurl has to be an instance field for the advertisingcallback to have scoped access to the url.

Thoughts?