search

google / play-services-plugins

Plugins to help with using Google Play services SDK.
https://developers.google.com/android/guides/overview
Apache License 2.0
471 stars 138 forks source link

Use the library name from the POM file of the dependency #191

Closed rekire closed 3 years ago

rekire commented 3 years ago

I want to have the clean name of the dependency if set in the POM file. My PR will use the name and will fallback when the name tag is not set in the POM file to the artifact group and artifact id. Fixes #184

rekire commented 3 years ago

I will fix the tests asap, tbh I forgot to run them

rekire commented 3 years ago

I fixed the tests and your remarks. There was one broken test file (groupB/bcd/deps2.pom) is was a copy of groupA/deps1.pom instead of a different test case, I fixed that. Could you please review why I had to change the expected output in testAddLicensesFromPom_withMultiple to pass the test? I do not get why this was required.

Thank you for the review!

rekire commented 3 years ago

Changed the code and merged my other PR into this one. I'm looking forward new feedback

rekire commented 3 years ago

@caller9 when I see this correctly then has my patch already landed in multiple Google Apps like the PlayStore, is there any timeframe when I can expect to see this in a public release?

rekire commented 2 years ago

My patch went live in 0.10.5 on February 28