google / play-unity-plugins

The Google Play Plugins for Unity provide C# APIs for accessing various Play services
Other
441 stars 115 forks source link

Fixed symbol zip file not being moved with Unity 2022, include non-batch mode build support. #239

Open trapezoid opened 9 months ago

trapezoid commented 9 months ago

Applied change #226 to address an issue in Unity 2022.1 and later where symbol files were no longer being moved correctly because they now include the name of the scripting backend in the symbol file name.

At that time, Fixed a bug that caused an exception to be thrown when executing a build in non-batch mode because PlayerSettings.GetScriptingBackend was accessed from outside the main thread.

google-cla[bot] commented 9 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

trapezoid commented 8 months ago

@google-admin

CLA check is already passed.

https://github.com/google/play-unity-plugins/pull/239/checks

Unless this PR is incorporated, I am unable to resolve symbol names in crash reports for applications built with play-unity-plugins in Unity 2022. We would be grateful if you could confirm this for us.