google / play-work

Apache License 2.0
85 stars 42 forks source link

Updated proto for the App Restrictions Schema Change Push Notifications. #8

Closed sergebeauchamp closed 9 years ago

sergebeauchamp commented 9 years ago

Change-Id: I62df458d65af76b425526c17cba1a9e890f67102

pinhuachen-okta commented 8 years ago

Hi, I'm trying to build this sample code, but getting this error. Seems like something added in this commit. Did I miss something?

main] [ERROR] protoc failed output: [main] [ERROR] protoc failed error: emm_pubsub.proto:126:35: Option "(datapol.semantic_type)" unknown.

sgzmd commented 8 years ago

Thanks for this report. We will take a look.

On Fri, 8 Jan 2016, 21:57 pinhuachen-okta notifications@github.com wrote:

Hi, I'm trying to build this sample code, but getting this error. Seems like something added in this commit. Did I miss something?

main] [ERROR] protoc failed output: [main] [ERROR] protoc failed error: emm_pubsub.proto:126:35: Option "(datapol.semantic_type)" unknown.

— Reply to this email directly or view it on GitHub https://github.com/google/play-work/pull/8#issuecomment-170139332.

pinhuachen-okta commented 8 years ago

Thank you @sergebeauchamp @sigizmund for the quick response. That's really helpful!

sergebeauchamp commented 8 years ago

Hello,

Apologies for the inconvenience, I will submit another pull request shortly.

In the mean time, you can change the following line:

optional string product_id = 1 [(datapol.semantic_type) = ST_SOFTWARE_ID];

to:

optional string product_id = 1;

Regards,

Serge.