search

google / playground-elements

Serverless coding environments for the web.
BSD 3-Clause "New" or "Revised" License
549 stars 55 forks source link

Gracefully handle a TypeScript compiler crash once #369

Closed AndrewJakubowicz closed 1 year ago

AndrewJakubowicz commented 1 year ago

Context

This fixes https://github.com/lit/lit.dev/issues/1128 by providing a path to gracefully recover from bad incremental state.

Testing

Manually confirmed this fix works - investigating adding unit testing.

Note that for the specific case that this PR was created, it's also viable to upgrade the bundled TypeScript which resolves the compiler error. A benefit of this solution is we could use it for other rare exceptions in the future.

AndrewJakubowicz commented 1 year ago

This is not needed since we upgraded TypeScript to 5.