search

google / pprof-nodejs

pprof support for Node.js
Apache License 2.0
251 stars 26 forks source link

test: update node versions in tests #210

Closed amchiclet closed 2 years ago

amchiclet commented 2 years ago

Related to #170, but doesn't completely fix it yet because node 18 tests are still failing. Here's the upstream tracking issue for source-map.

Updated workflow YAML file to test versions 12, 14, 16, 17, and 18. I needed to disable the fail-fast option; otherwise, any other test would be cancelled as soon as v18 fails.

Prebuilt binary tests depend on node-pre-gyp which only supports up to version 16 now, so version 17 and 18 aren't included in prebuilt binary tests.

Kokoro tests are also expected to fail for version 18, so for now will just make sure from the logs that the only failing test is for version 18 and the remaining versions pass.

nolanmar511 commented 2 years ago

Another option might be to drop tests for Node 18 until we're positioned to support Node 18. (Your call on what the right path forward is)

amchiclet commented 2 years ago

Tests are passing except for node 18 which is expected. Going to force merge this one, and will potentially work on another PR to workaround the node 18 issue.