Closed yosiat closed 8 months ago
Thanks for flagging this. It's actually fixed on main, we just need a release.
Thanks @aabmass , I saw it was released as 3.3.0
which is deprecated release.
Yes, I deprecated that one. IIRC it contained accidental breaking changes which should have been a major bump. I made a patch release instead to fix it
hey @aabmass is there any update on this one?
we are blocked on node 18 because of this, and the fix should be simple (unless I am missing something) - change nan from 2.14.0 to 2.17.0
@yosiat I'm working on a release right now. However, after checking what was published in pprof@3.2.1, I notice the version of nan has a carat dependency: https://github.com/google/pprof-nodejs/blob/d42aaa34775ac812b7f9b94c5d8e1913a36650b1/package.json#L35
IOW, you should be able to install it in Node 20 today. You might have an older version of nan in your package-lock.json
. Please try upgrading nan–I tested it in a fresh repo and it works.
@aabmass I agree with you that carat should work here, but it doesn't work as expected in my project.
It keeps installing nan v2.15.0
(and there is no other module depending on it except pprof), the only trick that worked is npm install nan
and then npm uninstall nan
, which is a bit weird one.
@yosiat I'm guessing it was probably stale from either your package-lock.json
or in node_modules
directory
Just published v4.0.0
Thanks a lot!
Hi,
I am trying to upgrade to node 20 (from 16) and I see this compilation error:
This issue looks like it's fixed in nan 2.17.0 - https://github.com/nodejs/nan/blob/main/CHANGELOG.md#2170-oct-10-2022
Is it possible to upgrade this dependency?