search

google / pprof-nodejs

pprof support for Node.js
Apache License 2.0
255 stars 26 forks source link

chore: fix CI to use newer npm on node 14 #298

Closed aabmass closed 1 month ago

aabmass commented 1 month ago

The npm version coming with Node 14 in Github Actions is v6 which does not support lockfile v3 checked into this repo:

npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@3. I'll try to do my best with it!

which results in non-hermetic build (see https://github.com/google/pprof-nodejs/pull/297). This PR upgrades npm to the newest version supported in Node 14, which understands the lockfile to pull in exact dependencies.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.92%. Comparing base (dead429) to head (37ddf4c). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #298 +/- ## ======================================= Coverage 41.92% 41.92% ======================================= Files 14 14 Lines 2092 2092 Branches 42 42 ======================================= Hits 877 877 Misses 1197 1197 Partials 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.