search

google / pprof

pprof is a tool for visualization and analysis of profiling data
Apache License 2.0
8.02k stars 607 forks source link

Add correct link for CI badge #763

Closed Rustin170506 closed 1 year ago

Rustin170506 commented 1 year ago

We should only show badges for main branch workflows, not PRs.

aalexand commented 1 year ago

I am not sure this change is necessary. I think the default is to show the status of the default branch, i.e. main. Do you have some evidence (documentation link or empirical) that this is not the case?

Rustin170506 commented 1 year ago

I am not sure this change is necessary. I think the default is to show the status of the default branch, i.e. main. Do you have some evidence (documentation link or empirical) that this is not the case?

For example:

image image
Rustin170506 commented 1 year ago

Oh, I see. It still failed. Because we canceled some tests on main branch workflows.

aalexand commented 1 year ago

The PR does not update the image URL.

And https://github.com/google/pprof/workflows/ci/badge.svg?branch=main is red anyway.

aalexand commented 1 year ago

I'm closing this. Totally feel free to re-open it with more evidence it is useful.

Rustin170506 commented 1 year ago

Thanks for your review! 💚 💙 💜 💛 ❤️

The PR does not update the image URL.

I just changed the link for the image. Anyway, maybe it doesn't matter. Thank you!