search

google / pprof

pprof is a tool for visualization and analysis of profiling data
Apache License 2.0
8.02k stars 607 forks source link

Fix broken URL parameters in new flame graph menus. #813

Closed ghemawat closed 1 year ago

ghemawat commented 1 year ago

Previously, we would pass an invalid 'f' URL parameter when switching from the new Flamegraph view to another view if nothing was selected. We now check for this case and avoid the bad behavior.

Also added a test for this behavior.

Fixes #812.

codecov-commenter commented 1 year ago

Codecov Report

Merging #813 (3e4b6c8) into main (f7f687d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #813   +/-   ##
=======================================
  Coverage   66.99%   66.99%           
=======================================
  Files          45       45           
  Lines        9861     9861           
=======================================
  Hits         6606     6606           
  Misses       2795     2795           
  Partials      460      460